Revert "Hide most of non-public symbols by default (#984 )"

This reverts commit da1c8d360e.
Hide most of non-public symbols by default (#984 )
2025-09-09 12:41:17 +00:00 · 2021-09-28 08:40:58 -05:00 · 2021-09-25 12:10:58 -05:00 · 2021-08-30 06:11:08 -05:00 · 2021-07-23 14:52:21 -05:00 · 2021-07-15 16:09:05 -05:00
8 changed files with 14 additions and 7 deletions
--- a/README.md
+++ b/README.md
@@ -59,3 +59,4 @@ The autogenerated API reference is hosted on [CodeDocs](https://codedocs.xyz/jbe
 The following projects are not officially supported:

 - [Qt wrapper](https://gist.github.com/brcha/d392b2fe5f1e427cc8a6)
+- [UnrealEngine Wrapper](https://github.com/jwindgassen/UnrealYAML)
--- a/include/yaml-cpp/exceptions.h
+++ b/include/yaml-cpp/exceptions.h
@@ -65,7 +65,7 @@ const char* const ZERO_INDENT_IN_BLOCK =
 const char* const CHAR_IN_BLOCK = "unexpected character in block scalar";
 const char* const AMBIGUOUS_ANCHOR =
    "cannot assign the same alias to multiple nodes";
-const char* const UNKNOWN_ANCHOR = "the referenced anchor is not defined";
+const char* const UNKNOWN_ANCHOR = "the referenced anchor is not defined: ";

 const char* const INVALID_NODE =
    "invalid node; this may result from using a map iterator as a sequence "
--- a/include/yaml-cpp/node/impl.h
+++ b/include/yaml-cpp/node/impl.h
@@ -42,7 +42,7 @@ inline Node::Node(const detail::iterator_value& rhs)
      m_pMemory(rhs.m_pMemory),
      m_pNode(rhs.m_pNode) {}

-inline Node::Node(const Node& rhs) = default;
+inline Node::Node(const Node&) = default;

 inline Node::Node(Zombie)
    : m_isValid(false), m_invalidKey{}, m_pMemory{}, m_pNode(nullptr) {}
--- a/include/yaml-cpp/node/iterator.h
+++ b/include/yaml-cpp/node/iterator.h
@@ -15,6 +15,9 @@
 #include <utility>
 #include <vector>

+// Assert in place so gcc + libc++ combination properly builds
+static_assert(std::is_constructible<YAML::Node, const YAML::Node&>::value, "Node must be copy constructable");
+
 namespace YAML {
 namespace detail {
 struct iterator_value : public Node, std::pair<Node, Node> {
--- a/src/singledocparser.cpp
+++ b/src/singledocparser.cpp
@@ -424,8 +424,11 @@ anchor_t SingleDocParser::RegisterAnchor(const std::string& name) {
 anchor_t SingleDocParser::LookupAnchor(const Mark& mark,
                                       const std::string& name) const {
  auto it = m_anchors.find(name);
-  if (it == m_anchors.end())
-    throw ParserException(mark, ErrorMsg::UNKNOWN_ANCHOR);
+  if (it == m_anchors.end()) {
+    std::stringstream ss;
+    ss << ErrorMsg::UNKNOWN_ANCHOR << name;
+    throw ParserException(mark, ss.str());
+  }

  return it->second;
 }
--- a/test/gtest-1.10.0/CMakeLists.txt
+++ b/test/gtest-1.10.0/CMakeLists.txt
@@ -1,7 +1,7 @@
 # Note: CMake support is community-based. The maintainers do not use CMake
 # internally.

-cmake_minimum_required(VERSION 2.8.8)
+cmake_minimum_required(VERSION 2.9)

 if (POLICY CMP0048)
  cmake_policy(SET CMP0048 NEW)
--- a/test/gtest-1.10.0/googlemock/CMakeLists.txt
+++ b/test/gtest-1.10.0/googlemock/CMakeLists.txt
@@ -42,7 +42,7 @@ else()
  cmake_policy(SET CMP0048 NEW)
  project(gmock VERSION ${GOOGLETEST_VERSION} LANGUAGES CXX C)
 endif()
-cmake_minimum_required(VERSION 2.6.4)
+cmake_minimum_required(VERSION 2.9)

 if (COMMAND set_up_hermetic_build)
  set_up_hermetic_build()
--- a/test/gtest-1.10.0/googletest/CMakeLists.txt
+++ b/test/gtest-1.10.0/googletest/CMakeLists.txt
@@ -53,7 +53,7 @@ else()
  cmake_policy(SET CMP0048 NEW)
  project(gtest VERSION ${GOOGLETEST_VERSION} LANGUAGES CXX C)
 endif()
-cmake_minimum_required(VERSION 2.6.4)
+cmake_minimum_required(VERSION 2.9)

 if (POLICY CMP0063) # Visibility
  cmake_policy(SET CMP0063 NEW)
Author	SHA1	Message	Date
Jesse Beder	54e63e3f8c	Revert "Hide most of non-public symbols by default (#984 )" This reverts commit `da1c8d360e`.	2021-09-28 08:40:58 -05:00
Pino Toscano	da1c8d360e	Hide most of non-public symbols by default (#984 ) * Export YAML::detail::node::m_amount The internal header node/detail/node.h is included by public headers; YAML::detail::node is implemented in the header itself, and thus it gets inlined... except for its static m_amount class member, which is instantiated in the library only. Right now all the symbols of yaml-cpp are exported (nothing is hidden), so the linker will find node::m_amount in the yaml-cpp library. As solution/workaround, explicitly export YAML::detail::node::m_amount. * CMake: use GenerateExportHeader Make use of the GenerateExportHeader CMake module to generate the dll.h header with export macros. While the produced dll.h is different, the result should be the same, i.e. nothing changes for yaml-cpp or its users. * CMake: hide all the symbols by default Hide all the symbols that are not explicitly exported with YAML_CPP_API. This way the ABI will be way smaller, and only actually exposing the public classes/functions.	2021-09-25 12:10:58 -05:00
jwindgassen	6308112e54	Added UE-Wrapper link to Readme (#1024 )	2021-08-30 06:11:08 -05:00
Snow Pettersen	db6deedcd3	Include name of anchor in invalid anchor error (#1015 )	2021-07-23 14:52:21 -05:00
mjvankampen	79aa6d53e5	Add assert to enable compilation with libcxx + gcc (#947 )	2021-07-15 16:09:05 -05:00
jbeach	ef0bba178d	Bump minimum cmake versions in gtest to eliminate cmake deprecation warnings. (#1012 )	2021-07-15 16:08:00 -05:00
JBPennington	b591d8ae2a	Update node impl.h for GCC unused variable warning (#981 ) Removed the variable name in the defaulted function to make GCC happy.	2021-07-10 11:07:12 -05:00