Make null handling YAML 1.2 compliant.

This commit is contained in:
TripleWhy
2016-04-02 00:14:59 +02:00
committed by Jesse Beder
parent 34bd1a7083
commit 52bcefa1f1
4 changed files with 10 additions and 6 deletions

View File

@@ -8,6 +8,7 @@
#endif #endif
#include "yaml-cpp/dll.h" #include "yaml-cpp/dll.h"
#include <string>
namespace YAML { namespace YAML {
class Node; class Node;
@@ -17,6 +18,7 @@ inline bool operator==(const _Null&, const _Null&) { return true; }
inline bool operator!=(const _Null&, const _Null&) { return false; } inline bool operator!=(const _Null&, const _Null&) { return false; }
YAML_CPP_API bool IsNull(const Node& node); // old API only YAML_CPP_API bool IsNull(const Node& node); // old API only
YAML_CPP_API bool IsNullString(const std::string& str);
extern YAML_CPP_API _Null Null; extern YAML_CPP_API _Null Null;
} }

View File

@@ -9,6 +9,7 @@
#include "stringsource.h" #include "stringsource.h"
#include "yaml-cpp/binary.h" // IWYU pragma: keep #include "yaml-cpp/binary.h" // IWYU pragma: keep
#include "yaml-cpp/ostream_wrapper.h" #include "yaml-cpp/ostream_wrapper.h"
#include "yaml-cpp/null.h"
namespace YAML { namespace YAML {
namespace Utils { namespace Utils {
@@ -152,12 +153,8 @@ void WriteCodePoint(ostream_wrapper& out, int codePoint) {
bool IsValidPlainScalar(const std::string& str, FlowType::value flowType, bool IsValidPlainScalar(const std::string& str, FlowType::value flowType,
bool allowOnlyAscii) { bool allowOnlyAscii) {
if (str.empty()) {
return false;
}
// check against null // check against null
if (str == "null") { if (IsNullString(str)) {
return false; return false;
} }

View File

@@ -2,4 +2,8 @@
namespace YAML { namespace YAML {
_Null Null; _Null Null;
bool IsNullString(const std::string& str) {
return str.empty() || str == "~" || str == "null" || str == "Null" || str == "NULL";
}
} }

View File

@@ -11,6 +11,7 @@
#include "yaml-cpp/eventhandler.h" #include "yaml-cpp/eventhandler.h"
#include "yaml-cpp/exceptions.h" // IWYU pragma: keep #include "yaml-cpp/exceptions.h" // IWYU pragma: keep
#include "yaml-cpp/mark.h" #include "yaml-cpp/mark.h"
#include "yaml-cpp/null.h"
namespace YAML { namespace YAML {
SingleDocParser::SingleDocParser(Scanner& scanner, const Directives& directives) SingleDocParser::SingleDocParser(Scanner& scanner, const Directives& directives)
@@ -75,7 +76,7 @@ void SingleDocParser::HandleNode(EventHandler& eventHandler) {
const Token& token = m_scanner.peek(); const Token& token = m_scanner.peek();
if (token.type == Token::PLAIN_SCALAR && token.value == "null") { if (token.type == Token::PLAIN_SCALAR && IsNullString(token.value)) {
eventHandler.OnNull(mark, anchor); eventHandler.OnNull(mark, anchor);
m_scanner.pop(); m_scanner.pop();
return; return;