mirror of
				https://github.com/ggml-org/llama.cpp.git
				synced 2025-10-31 08:51:55 +00:00 
			
		
		
		
	server tests : more pythonic process management; fix bare except: (#6146)
				
					
				
			* server tests : remove seemingly redundant newlines in print() * server tests : use built-in subprocess features, not os.kill and psutil * server tests : do not catch e.g. SystemExit; use print_exc * server tests: handle TimeoutExpired exception * server tests: fix connect on dual-stack systems * server: tests: add new tokens regex on windows generated following new repeat penalties default changed in (#6127) * server: tests: remove the hack on windows since now we get the good socket family * server: tests: add new tokens regex following new repeat penalties default changed in (#6127) * server: tests: add new tokens regex following new repeat penalties default changed in (#6127) --------- Co-authored-by: Pierrick HYMBERT <pierrick.hymbert@gmail.com>
This commit is contained in:
		| @@ -5,15 +5,14 @@ import sys | ||||
| import time | ||||
| import traceback | ||||
| from contextlib import closing | ||||
|  | ||||
| import psutil | ||||
| from subprocess import TimeoutExpired | ||||
|  | ||||
|  | ||||
| def before_scenario(context, scenario): | ||||
|     context.debug = 'DEBUG' in os.environ and os.environ['DEBUG'] == 'ON' | ||||
|     if context.debug: | ||||
|         print("DEBUG=ON\n") | ||||
|     print(f"\x1b[33;42mStarting new scenario: {scenario.name}!\x1b[0m\n") | ||||
|         print("DEBUG=ON") | ||||
|     print(f"\x1b[33;42mStarting new scenario: {scenario.name}!\x1b[0m") | ||||
|     port = 8080 | ||||
|     if 'PORT' in os.environ: | ||||
|         port = int(os.environ['PORT']) | ||||
| @@ -27,60 +26,40 @@ def after_scenario(context, scenario): | ||||
|             return | ||||
|         if scenario.status == "failed": | ||||
|             if 'GITHUB_ACTIONS' in os.environ: | ||||
|                 print(f"\x1b[33;101mSCENARIO FAILED: {scenario.name} server logs:\x1b[0m\n\n") | ||||
|                 print(f"\x1b[33;101mSCENARIO FAILED: {scenario.name} server logs:\x1b[0m\n") | ||||
|                 if os.path.isfile('llama.log'): | ||||
|                     with closing(open('llama.log', 'r')) as f: | ||||
|                         for line in f: | ||||
|                             print(line) | ||||
|             if not is_server_listening(context.server_fqdn, context.server_port): | ||||
|                 print("\x1b[33;101mERROR: Server stopped listening\x1b[0m\n") | ||||
|                 print("\x1b[33;101mERROR: Server stopped listening\x1b[0m") | ||||
|  | ||||
|         if not pid_exists(context.server_process.pid): | ||||
|         if context.server_process.poll() is not None: | ||||
|             assert False, f"Server not running pid={context.server_process.pid} ..." | ||||
|  | ||||
|         server_graceful_shutdown(context) | ||||
|         server_graceful_shutdown(context)  # SIGINT | ||||
|  | ||||
|         # Wait few for socket to free up | ||||
|         time.sleep(0.05) | ||||
|         try: | ||||
|             context.server_process.wait(0.5) | ||||
|         except TimeoutExpired: | ||||
|             print(f"server still alive after 500ms, force-killing pid={context.server_process.pid} ...") | ||||
|             context.server_process.kill()  # SIGKILL | ||||
|             context.server_process.wait() | ||||
|  | ||||
|         attempts = 0 | ||||
|         while pid_exists(context.server_process.pid) or is_server_listening(context.server_fqdn, context.server_port): | ||||
|             server_kill(context) | ||||
|         while is_server_listening(context.server_fqdn, context.server_port): | ||||
|             time.sleep(0.1) | ||||
|             attempts += 1 | ||||
|             if attempts > 5: | ||||
|                 server_kill_hard(context) | ||||
|     except: | ||||
|         exc = sys.exception() | ||||
|         print("error in after scenario: \n") | ||||
|         print(exc) | ||||
|         print("*** print_tb: \n") | ||||
|         traceback.print_tb(exc.__traceback__, file=sys.stdout) | ||||
|     except Exception: | ||||
|         print("ignoring error in after_scenario:") | ||||
|         traceback.print_exc(file=sys.stdout) | ||||
|  | ||||
|  | ||||
| def server_graceful_shutdown(context): | ||||
|     print(f"shutting down server pid={context.server_process.pid} ...\n") | ||||
|     print(f"shutting down server pid={context.server_process.pid} ...") | ||||
|     if os.name == 'nt': | ||||
|         os.kill(context.server_process.pid, signal.CTRL_C_EVENT) | ||||
|         interrupt = signal.CTRL_C_EVENT | ||||
|     else: | ||||
|         os.kill(context.server_process.pid, signal.SIGINT) | ||||
|  | ||||
|  | ||||
| def server_kill(context): | ||||
|     print(f"killing server pid={context.server_process.pid} ...\n") | ||||
|     context.server_process.kill() | ||||
|  | ||||
|  | ||||
| def server_kill_hard(context): | ||||
|     pid = context.server_process.pid | ||||
|     path = context.server_path | ||||
|  | ||||
|     print(f"Server dangling exits, hard killing force {pid}={path}...\n") | ||||
|     try: | ||||
|         psutil.Process(pid).kill() | ||||
|     except psutil.NoSuchProcess: | ||||
|         return False | ||||
|     return True | ||||
|         interrupt = signal.SIGINT | ||||
|     context.server_process.send_signal(interrupt) | ||||
|  | ||||
|  | ||||
| def is_server_listening(server_fqdn, server_port): | ||||
| @@ -88,14 +67,5 @@ def is_server_listening(server_fqdn, server_port): | ||||
|         result = sock.connect_ex((server_fqdn, server_port)) | ||||
|         _is_server_listening = result == 0 | ||||
|         if _is_server_listening: | ||||
|             print(f"server is listening on {server_fqdn}:{server_port}...\n") | ||||
|             print(f"server is listening on {server_fqdn}:{server_port}...") | ||||
|         return _is_server_listening | ||||
|  | ||||
|  | ||||
| def pid_exists(pid): | ||||
|     try: | ||||
|         psutil.Process(pid) | ||||
|     except psutil.NoSuchProcess: | ||||
|         return False | ||||
|     return True | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Jared Van Bortel
					Jared Van Bortel