CS348Project/llama.cpp
5
0
Fork 0
mirror of https://github.com/ggml-org/llama.cpp.git synced 2025-10-29 08:41:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci : reduce severity of unused Pyright ignore comments

Browse Source
This commit is contained in:
Francis Couture-Harpin
2024-09-30 13:29:08 -04:00
parent 08a43d05b6
commit a34fc0dd86
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/python-type-check.yml vendored
View File

@@ -4,11 +4,13 @@ on:
push: push:
paths: paths:
- '.github/workflows/python-type-check.yml' - '.github/workflows/python-type-check.yml'
- 'pyrightconfig.json'
- '**.py' - '**.py'
- '**/requirements*.txt' - '**/requirements*.txt'
pull_request: pull_request:
paths: paths:
- '.github/workflows/python-type-check.yml' - '.github/workflows/python-type-check.yml'
- 'pyrightconfig.json'
- '**.py' - '**.py'
- '**/requirements*.txt' - '**/requirements*.txt'
@@ -33,6 +35,6 @@ jobs:
- name: Type-check with Pyright - name: Type-check with Pyright
uses: jakebailey/pyright-action@v2 uses: jakebailey/pyright-action@v2
with: with:
version: 1.1.370 version: 1.1.382
level: warning level: warning
warnings: true warnings: true

4
examples/llava/convert_image_encoder_to_gguf.py
View File

@@ -274,7 +274,7 @@ fout.add_bool("clip.use_gelu", use_gelu)
if has_llava_projector: if has_llava_projector:
model.vision_model.encoder.layers.pop(-1) # pyright: ignore[reportAttributeAccessIssue] model.vision_model.encoder.layers.pop(-1)
projector = torch.load(args.llava_projector) projector = torch.load(args.llava_projector)
for name, data in projector.items(): for name, data in projector.items():
name = get_tensor_name(name) name = get_tensor_name(name)
@@ -288,7 +288,7 @@ if has_llava_projector:
print("Projector tensors added\n") print("Projector tensors added\n")
state_dict = model.state_dict() # pyright: ignore[reportAttributeAccessIssue] state_dict = model.state_dict()
for name, data in state_dict.items(): for name, data in state_dict.items():
if should_skip_tensor(name, has_text_encoder, has_vision_encoder, has_llava_projector): if should_skip_tensor(name, has_text_encoder, has_vision_encoder, has_llava_projector):
# we don't need this # we don't need this

3
pyrightconfig.json
View File

@@ -5,7 +5,8 @@
"reportUnusedImport": "warning", "reportUnusedImport": "warning",
"reportDuplicateImport": "error", "reportDuplicateImport": "error",
"reportDeprecated": "warning", "reportDeprecated": "warning",
"reportUnnecessaryTypeIgnoreComment": "warning", "reportUnnecessaryTypeIgnoreComment": "information",
"disableBytesTypePromotions": false, // TODO: change once Python 3.12 is the minimum
"executionEnvironments": [ "executionEnvironments": [
{ {
// TODO: make this version override work correctly // TODO: make this version override work correctly