From a2fba89a426ff8005d303c73f0436e7e67368b70 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Sun, 12 Oct 2025 07:19:06 +0200 Subject: [PATCH] hparams : add check for layer index in is_recurrent (#16511) * hparams : add check for layer index in is_recurrent This commit adds a check in the is_recurrent method to ensure that the provided layer index is within the valid range. The motivation for this change is to prevent potential out-of-bounds and also be consistent with other methods in the class that perform similar checks, like is_swa. --- src/llama-hparams.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/llama-hparams.cpp b/src/llama-hparams.cpp index c04ac58f1a..db65d69eab 100644 --- a/src/llama-hparams.cpp +++ b/src/llama-hparams.cpp @@ -140,7 +140,11 @@ uint32_t llama_hparams::n_embd_s() const { } bool llama_hparams::is_recurrent(uint32_t il) const { - return recurrent_layer_arr[il]; + if (il < n_layer) { + return recurrent_layer_arr[il]; + } + + GGML_ABORT("%s: il (%u) out of bounds (n_layer: %u)\n", __func__, il, n_layer); } uint32_t llama_hparams::n_pos_per_embd() const {