CS348Project/llama.cpp
5
0
Fork 0
mirror of https://github.com/ggml-org/llama.cpp.git synced 2025-11-06 09:46:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-backend-ops : fix segfault in moe-expert-reduce test in support mode and coverage (#16936)

Browse Source 
* tests: fix segfault in moe-expert-reduce test in support mode and --show-coverage

* tests: init gf and filter out fusion tests for support mode

* tests: filter out fusion cases before calling eval_support

* tests: filter out fusion cases from show_test_coverage as well, fix lint
This commit is contained in:
Shagun Bera
2025-11-03 04:40:30 +05:30
committed by GitHub
parent dd52868050
commit a2054e3a8f
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/test-backend-ops.cpp
View File

@@ -1454,6 +1454,8 @@ struct test_case {
ggml_context_ptr ctx(ggml_init(params)); // smart ptr ggml_context_ptr ctx(ggml_init(params)); // smart ptr
GGML_ASSERT(ctx); GGML_ASSERT(ctx);
gf = ggml_new_graph_custom(ctx.get(), graph_nodes, false);
ggml_tensor * out = build_graph(ctx.get()); ggml_tensor * out = build_graph(ctx.get());
current_op_name = op_desc(out); current_op_name = op_desc(out);
@@ -7569,6 +7571,15 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
if (mode == MODE_SUPPORT) { if (mode == MODE_SUPPORT) {
auto test_cases = make_test_cases_eval(); auto test_cases = make_test_cases_eval();
filter_test_cases(test_cases, params_filter); filter_test_cases(test_cases, params_filter);
// Filter out fusion cases
test_cases.erase(
std::remove_if(test_cases.begin(), test_cases.end(), [](const std::unique_ptr<test_case> & tc) {
return tc->run_whole_graph();
}),
test_cases.end()
);
for (auto & test : test_cases) { for (auto & test : test_cases) {
test->eval_support(backend, op_names_filter, output_printer); test->eval_support(backend, op_names_filter, output_printer);
} }
@@ -7619,6 +7630,14 @@ static void show_test_coverage() {
all_ops.insert(ggml_glu_op_name((enum ggml_glu_op)i)); all_ops.insert(ggml_glu_op_name((enum ggml_glu_op)i));
} }
auto test_cases = make_test_cases_eval(); auto test_cases = make_test_cases_eval();
// Filter out fusion cases
test_cases.erase(
std::remove_if(test_cases.begin(), test_cases.end(), [](const std::unique_ptr<test_case> & tc) {
return tc->run_whole_graph();
}),
test_cases.end()
);
std::set<std::string> tested_ops; std::set<std::string> tested_ops;
ggml_init_params params = { ggml_init_params params = {